ci: add shear and zizmor checks, and move heavy GitHub Actions jobs to WarpBuild#2826
Conversation
6f45b6a to
cf68b1a
Compare
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good to me!
| [lib] | ||
| doctest = false |
There was a problem hiding this comment.
This disables running doctest by default, right? If so, doesn't this increase the risk of not running them when not using a make command? Or what's the benefit of disabling these?
There was a problem hiding this comment.
The lint is doctest_enabled_without_doctests: this removes a vacuous run, something which can and should be reversed when we add doc tests.
cf68b1a to
eaa6129
Compare
partylikeits1983
left a comment
There was a problem hiding this comment.
Looks great! One question though. The new workspace criterion pin is 0.5, but bin/bench-note-checker and bin/bench-transaction were both on 0.6 before this PR. Swapping their dev-dep to workspace = true quietly downgrades them. Could you confirm the downgrade is intentional? If it's not too difficult, would it make sense to bump the workspace pin to 0.6 and update miden-protocol's dev-dep alongside, to keep the bench crates where they were?
|
@partylikeits1983 Yup it's intentional: keeping the workspace at criterion 0.6 would require removing the pproof-rs integration in benchmarks (or allowing two versions of the same crate). Lmk if there is one solution we can get reasonable alignment on. |
cargo-shear, an upgrade fromcargo-machete.cargo shearlooks not only for unused dependencies (better than machete, as shown by this PR's removals), but also for those put in the wrong dependency section.zizmorscans GitHub Actions files for risky patterns, like loose action pins or unsafe defaults.The PR also removes the unused dependencies that
shearfound, pins action versions more tightly, and fixes feature-flag issues.