Assorted tweaks to support external playground crate#322
Merged
Conversation
arnaucube
reviewed
Jul 1, 2025
Collaborator
arnaucube
left a comment
arnaucube
left a comment
There was a problem hiding this comment.
LGTM! just left a small question
| } | ||
| } | ||
|
|
||
| impl ToHex for RawValue { |
Collaborator
There was a problem hiding this comment.
One question, I see that before this PR, the type Hash had implementations for the traits ToHex and FromHex. Here it is introducing ToHex for the type RawValue; should we add also the implementation of FromHex for the type RawValue? (so that it is available in the future for when converting back and forth the RawValue from & to hex)
Collaborator
Author
There was a problem hiding this comment.
I've added the FromHex trait as well.
arnaucube
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are various tweaks which allow the playground crate to import pod2 as an external crate. In particular, the
examplesfeature allows external crates to import things like the Ethdos batch.The other changes are mostly adding some extra
derives or methods to make crate-private fields accessible.