feat(backend): use custom gate for Schnorr signature verification#397
Merged
ax0 merged 11 commits into0xPARC:mainfrom Sep 3, 2025
Merged
feat(backend): use custom gate for Schnorr signature verification#397ax0 merged 11 commits into0xPARC:mainfrom
ax0 merged 11 commits into0xPARC:mainfrom
Conversation
ed255
reviewed
Aug 27, 2025
Collaborator
ed255
left a comment
ed255
left a comment
There was a problem hiding this comment.
I've done an initial review pass. I've reviewed all files except for src/backends/plonky2/primitives/ec/gates/curve.rs
dgulotta
approved these changes
Sep 2, 2025
Collaborator
dgulotta
left a comment
dgulotta
left a comment
There was a problem hiding this comment.
There are a few minor things that can be cleaned up, but otherwise it looks good!
ed255
added a commit
that referenced
this pull request
Sep 8, 2025
- Update formula in `estimate_verif_num_gates` after the update in the recursive verification from #397 - Update the parameters to get better utilization of 2^16 rows - Update metrics report to be more compact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #385.