Conversation
ed255
approved these changes
Feb 16, 2026
Collaborator
ed255
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses two nondeterminism cases:
The first issue came during predicate splitting: we were storing candidate statement indices in a
HashSet, and then picking the "best" one withmax_by_key.Most of the time that’s fine, because the scoring function picks a clear winner. But in tie cases, where two statements have exactly the same primary score and secondary tie-breaker metrics,
max_by_keyeffectively falls back to iterator order. With aHashSet, that iteration order is non-deterministic.That meant the chosen "best next statement" could vary from run to run in those tie situations. Once that first difference happens, downstream ordering, split boundaries, and promoted wildcard sets can also differ, even though the input predicate is identical.
The fix was to make tie resolution explicit and deterministic. The selection key is now
(primary_score, tie_breakers, Reverse(idx)). Sincemax_by_keychooses the maximum key,Reverse(idx)makes smaller indices rank higher in otherwise-equal cases.The second issue affected only diagnostic messages, and has been resolved by ensuring a sort order on the message elements.