Conversation
arnaucube
approved these changes
Feb 27, 2025
Collaborator
arnaucube
left a comment
arnaucube
left a comment
There was a problem hiding this comment.
LGTM!
just left a couple of small comments
Comment on lines
+49
to
+52
| ## `Raw` | ||
| "Raw" is short for "raw value". A `Raw` exposes a backend value on the frontend. | ||
|
|
||
| With the plonky2 backend, a `Raw` is a tuple of 4 elements of the Goldilocks field. |
Collaborator
There was a problem hiding this comment.
is the Raw in this section equivalent to the Value type at the section backendtypes.md?
|
|
||
| ## Compound types | ||
|
|
||
| The three front-end compound types (`Dictionary`, `Array`, `Set`) are all represented as Merkle roots on the backend. The details of the representation are explained on a separate [Merkle tree](./merkletree.md) page. No newline at end of file |
Collaborator
There was a problem hiding this comment.
We will need to define (not necessarily now in this PR) where the Dictionary,Array,Set belong: here they appear in the Backend section referencing the merkletree.md file, on the same time they are described at the Frontend subsection values.md file; and in the code they are implemented in the middleware.
… moved out of values.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made some improvements to the docs.
Mostly just reorganizing existing content, but added some new material on front and back ends.