feat: OpenRouter streaming with Parallel Tool Calls#379
Closed
piotrostr wants to merge 17 commits into0xPlaygrounds:mainfrom
Closed
feat: OpenRouter streaming with Parallel Tool Calls#379piotrostr wants to merge 17 commits into0xPlaygrounds:mainfrom
piotrostr wants to merge 17 commits into0xPlaygrounds:mainfrom
Conversation
Contributor
piotrostr
commented
Apr 3, 2025
piotrostr
commented
- pass on IDs as well
- fix serde
0xMochan
requested changes
Apr 3, 2025
Contributor
0xMochan
left a comment
0xMochan
left a comment
There was a problem hiding this comment.
Some debug FIXME's left behind!
| let mut request = self.create_completion_request(completion_request)?; | ||
|
|
||
| request = merge(request, json!({"stream": true})); | ||
| if std::env::var("DEBUG").is_ok() { |
Contributor
There was a problem hiding this comment.
should be converted into a debug! tracing call or removed
| } | ||
| } | ||
|
|
||
| // FIXME remove this |
| continue; | ||
| }; | ||
|
|
||
| // FIXME remove this |
| }; | ||
|
|
||
| yield Ok(streaming::StreamingChoice::ToolCall(name, "".to_string(), arguments)) | ||
| if std::env::var("DEBUG").is_ok() { |
piotrostr
changed the title
piotrostr
changed the title
Contributor
|
The plan for this PR is to (manually) cherry pick the changes into the streaming refactor from #388 . |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.