ethapi: include pre-Madhugiri state-sync logs in bor_getLogs#2155
Merged
manav2401 merged 2 commits intoApr 7, 2026
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Author
|
@claude review |
manav2401
reviewed
Apr 1, 2026
Member
manav2401
left a comment
manav2401
left a comment
There was a problem hiding this comment.
LGTM - one small nit. Instead of tests calling the parent functions which uses the getBlockAndReceipts, can you simplify it to just test getBlockAndReceipts independently? Thanks!
|
Contributor
Author
|
@manav2401 Updated, sir. |
manav2401
approved these changes
Apr 1, 2026
cffls
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include pre-Madhugiri Bor state-sync receipts when collecting logs for bor_getLogs and bor_getLatestLogs, and add regression coverage for the historical state-sync log path.