miner: disable tracer in vm.Config to prevent conflicts during block synchronization#2206
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR prevents mining-time EVM execution from invoking the chain-level vm.Config.Tracer hooks, avoiding conflicts when “live tracing” is enabled during block synchronization.
Changes:
- In
miner/worker.go, explicitly clearsvm.Config.Tracerin the miner’s derived VM config to ensure tracing hooks don’t run during block production.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@maoueh apologies for the delay - can you merge the latest develop which has some CI fixes? I'll get this one merged once done. Thanks! |
|
Hey @maoueh looks like commits from agent are unverified and github won't allow merging. If possible can you sign them? Thanks! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pratikspatil024
force-pushed
the
fix/miner-no-live-tracing
branch
from
d8b0509 to
b3738cd
Compare
|
|
Seems merged, so I assume all good. |
Description
If running
borwith live tracing enabled, once reaching live, miner starts to also call the live tracing hooks causing problems because only the block synchronization should call the live tracer.Changes
Breaking changes
None
Nodes audience
People running Live Tracing + bor
Testing