packaging/docs: replace deprecated rpc.batchlimit key#2216
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2216 +/- ##
===========================================
+ Coverage 52.30% 52.33% +0.02%
===========================================
Files 885 885
Lines 155715 155715
===========================================
+ Hits 81450 81489 +39
+ Misses 69030 68998 -32
+ Partials 5235 5228 -7 see 15 files with indirect coverage changes 🚀 New features to boost your workflow:
|
pratikspatil024
left a comment
There was a problem hiding this comment.
Thank you!
Can you update the default value to 1000? Also make sure to run make docs.
|
Thanks @odupontt - is it possible for you to sign this commit? You can rebase locally to rewrite history with signed commits and force-push. |
3db8810 to
c9bfba0
Compare
|
Hi @pratikspatil024 - Done, I rebased and force-pushed the branch with signed commits; the latest commit (c9bfba0) is now Verified. |
|
Thanks @odupontt - did you also run |
@pratikspatil024 yes, I ran make docs and it produced no changes. |



Description
This PR fixes a real configuration correctness issue caused by a key mismatch between runtime config parsing and shipped templates/docs.
internal/cli/server/config.gonow expectsrpc.batch-request-limit, but multiple template files and the CLI example still usedrpc.batchlimit.If operators uncommented the old key, Bor silently ignored it and kept the default batch request limit (
1000), which could lead to unexpected production behavior.What was done:
rpc.batchlimitwithrpc.batch-request-limitin all affected packaging templates.builder/files/config.tomlto use the correct key.docs/cli/example_config.tomlto keep docs/examples aligned with runtime behavior.Changes
Nodes audience
This change applies to all operators who rely on shipped Bor templates/examples.
It is not limited to a subset of nodes.
Checklist
Cross repository changes
Testing
Manual tests
rg -n "rpc\.batchlimit" .rg -n "rpc\.batch-request-limit" builder packaging docsAdditional comments
No runtime code path or default value was changed in this PR; this is a template/docs correctness alignment fix to prevent silent misconfiguration.