miner: fix TestPrefetchRaceWithSetExtra deadlock#2233
Merged
pratikspatil024 merged 2 commits intoMay 26, 2026
Conversation
… send Assisted-by: Claude:claude-sonnet-4-6
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
lucca30
approved these changes
May 25, 2026
|
manav2401
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I saw this test failure on
developwhen I forked.The timeout is likely caused by a deadlock, and this seems to be a good candidate fix.
If the channel is full, then this worker can hang.
Moving the channel operation into the select makes it nonblocking.
However I do not know the context or intent of this test so this may not be the right fix.
Executed tests
Only reran the flaky test
Rollout notes
Nonbreaking