fix: loadtestrpc mode erc20/721 contract addresses nil#262
Merged
Conversation
jhkimqd
force-pushed
the
jihwan/loadtestrpc
branch
2 times, most recently
from
7680d79 to
91a16d6
Compare
praetoriansentry
previously approved these changes
Apr 19, 2024
…c mode fix: keccak counter issue with erc721 deployment Signed-off-by: Ji Hwan <jkim@polygon.technology>
jhkimqd
force-pushed
the
jihwan/loadtestrpc
branch
from
91a16d6 to
d122be7
Compare
leovct
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running loadtestrpc mode, a random call to an ERC20 contract may be made, and it could be nil, causing the loop to fail. This PR checks if the contract address is nil and fills it with a deployed contract's address.
Testing
Before
After