feat: blob mode for loadtest #292
Merged
Merged
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | Generic High Entropy Secret | 8d9038c | cmd/loadtest/loadtest.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Signed-off-by: Ji Hwan <jkim@polygon.technology>
6a34103 to
8d9038c
Compare
leovct
reviewed
Jun 3, 2024
leovct
previously approved these changes
Jun 3, 2024
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Member
I was thinking more along the lines of:
What do you think? |
leovct
reviewed
Jun 3, 2024
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
leovct
approved these changes
Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes blob mode for
polycli loadtest. The new mode sends an EIP-4844 blob transaction. Usage is identical to other loadtest modes e.g.-loadtest --requests 10 --rpc-url <rpc_url> --to-random --verbosity 700 --rate-limit 1 --concurrency 1 --mode \"blob\" --private-key <private_key>will send 10 blob transactions with randomly generated blob and its sidecars:The blob fee cap is adjustable using the
--blob-fee-capflag, and the default value is at 100,000 Gwei.Jira / Linear Tickets
Testing
Tested on a Kurtosis-CDK Geth node.
Blob transaction using cast shows a successful transaction of type
0x03Blob transaction using
polycli loadtest --mode "blob"similarly shows the same transaction type when queried usingcast receipt <blob_txn_hash>