makes code generation to use docker instead of locally installed tools#551
Merged
makes code generation to use docker instead of locally installed tools#551
Conversation
This reverts commit 28e30c3.
leovct
approved these changes
Mar 19, 2025
Member
leovct
left a comment
leovct
left a comment
There was a problem hiding this comment.
lgtm, tested locally and it works fine!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #511
closes #523
The make commands
gen-doc,gen-proto,gen-go-bindings,gen-loadtest-modes,gen-json-rpctypeswill now be executed inside a container to avoid requiring tools installed locally with the same version as the ones used in the CI.CI workflow was also updated to run each generated code verification in a different job, allowing these jobs to be verified simultaneously.