feat(dumpblocks): fix range; get receipts by block #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the range calculation in the dumpblocks command and extends the GetReceipts method to support getting receipts by block with a fallback to getting them by transaction hash.
- Fixed off-by-one error in block range iteration logic
- Added support for
eth_getBlockReceiptsRPC method with fallback to existing transaction-based approach - Refactored receipt fetching into separate functions for better maintainability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/dumpblocks/dumpblocks.go | Fixed range calculation to use inclusive end boundary and correct range advancement |
| util/util.go | Added block-based receipt fetching with fallback and refactored existing logic into separate function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
minhd-vu
changed the title
* feat: adding command to parse batchl2 data * fix: issue with rpc flags * Update cmd/parsebatchl2data/parsebatchl2data.go Co-authored-by: Léo Vincent <28714795+leovct@users.noreply.github.com> * fix: flag_loader import * fix: lint * fix: err shadow * fix: handle errors from printTxData --------- Co-authored-by: Minh Vu <minhd_vu@yahoo.com> Co-authored-by: Léo Vincent <28714795+leovct@users.noreply.github.com> Co-authored-by: Minh Vu <mvu@polygon.technology>
minhd-vu
reviewed
Oct 2, 2025
minhd-vu
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/0xPolygon/devtools/issues/418
utils.GetReceiptsmethod to get receipts by block, with a fallback to get them by tx