feat(ulxly): add --proof-l1-info-tree-index flag for claim asset and message #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gkit bridge service
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying a custom L1 Info Tree Index when claiming assets or messages through the aggkit bridge service. The new --proof-l1-info-tree-index flag allows users to override the automatic L1 Info Tree Index resolution that normally occurs via network_id and deposit_count.
Key changes:
- Added new CLI flag
--proof-l1-info-tree-indexfor claim asset and message commands - Refactored bridge service interface to support multiple proof generation methods
- Updated documentation to reflect the new flag option
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/ulxly/ulxly.go | Added flag handling and updated proof generation logic to support L1 Info Tree Index override |
| cmd/ulxly/bridge_service/interface.go | Refactored interface to separate proof methods by source (default, GER, L1InfoTreeIndex) |
| cmd/ulxly/bridge_service/legacy/service.go | Implemented new interface methods, added error handling for unsupported L1InfoTreeIndex |
| cmd/ulxly/bridge_service/aggkit/service.go | Refactored proof generation logic to support L1InfoTreeIndex parameter |
| doc/*.md | Updated documentation to include the new flag description |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
praetoriansentry
previously approved these changes
Oct 10, 2025
praetoriansentry
approved these changes
Oct 13, 2025
minhd-vu
pushed a commit
that referenced
this pull request
Oct 14, 2025
…message (#726) * ulxly: add l1-info-tree-index flag for claim asset and message for aggkit bridge service * make proof-ger and proog-l1-info-tree-index mutually exclusive
minhd-vu
pushed a commit
that referenced
this pull request
Oct 14, 2025
…message (#726) * ulxly: add l1-info-tree-index flag for claim asset and message for aggkit bridge service * make proof-ger and proog-l1-info-tree-index mutually exclusive
minhd-vu
pushed a commit
that referenced
this pull request
Oct 14, 2025
…message (#726) * ulxly: add l1-info-tree-index flag for claim asset and message for aggkit bridge service * make proof-ger and proog-l1-info-tree-index mutually exclusive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/0xPolygon/devtools/issues/419
The
aggkit bridge servicerequires thel1-info-tree-indexto be provided to generate the proof for claiming anassetormessage. Thel1-info-tree-indexis loaded automatically using thenetwork_idanddeposit_count.The new flag
--proof-l1-info-tree-indexallows the user to force a specificl1 info tree indexwhile claiming anassetormessagevia theaggkit bridge service