Skip to content

fix(sensor): getParentBlock short-circuit #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
minhd-vu merged 1 commit into from
Oct 28, 2025
Merged

fix(sensor): getParentBlock short-circuit #762

minhd-vu merged 1 commit into from
Oct 28, 2025

Conversation

@minhd-vu
Copy link
Contributor

@minhd-vu minhd-vu commented Oct 24, 2025 •
edited
Loading

Description

  • Fixes the getParentBlock method to not short-circuit based on the --write-block-events flag.
  • JSON db now returns false to having a block because the centralized block cache should ideally have it.

Jira / Linear Tickets

Testing

  • 👀
  • Deployed Amoy
  • Deployed Mainnet

@minhd-vu minhd-vu merged commit 9dc17a3 into main Oct 28, 2025
15 checks passed
@minhd-vu minhd-vu deleted the minhd-vu/fix-get-parent-block branch October 28, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xavier-romero xavier-romero xavier-romero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@minhd-vu @xavier-romero