This repository was archived by the owner on Feb 17, 2025. It is now read-only.
EncodeBatchV2 allow to set Tx in binary #3143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanestebanr
requested review from
ARR552,
ToniRamirezM and
tclemos
as code owners
dpunish3r
approved these changes
Jan 25, 2024
agnusmor
approved these changes
Jan 25, 2024
ToniRamirezM
approved these changes
Jan 26, 2024
joanestebanr
deleted the
feature/3132_encode_batches_with_tx_in_binary
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3132
What does this PR do?
EncodeBatchV2allow to set Tx directly encoded.struct
L2TxRawhave a fieldalreadyEncodedthat says if it's encodedReviewers
Main reviewers: