fix: use bigint accumulator in native sell reduce#103
Merged
hzhu merged 2 commits into0xProject:mainfrom Mar 16, 2026
Merged
Conversation
The reduce that aggregates multiple ERC-20 transfer logs for native sell swaps was round-tripping through formatUnits → BigInt, causing a SyntaxError on the 2nd+ iteration because BigInt() cannot parse decimal strings. This aligns the pattern with the existing safe reduce at line 100-104 by tracking amountRaw as a bigint through the accumulator. Fixes 0xProject#102
Keep amountRaw internal to the reduce accumulator instead of leaking it into the public response, consistent with all other return paths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hzhu
approved these changes
Mar 16, 2026
Member
hzhu
left a comment
hzhu
left a comment
There was a problem hiding this comment.
🧪 tests pass, coverage remains at 100%
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SyntaxError: Cannot convert X to a BigIntwhen a native sell swap produces 2+ ERC-20 transfer logs to the same recipient (e.g., partial fills, rebates, multi-hop)reduceaccumulator was round-tripping throughformatUnits→BigInt, butBigInt()cannot parse decimal strings on the 2nd+ iterationamountRawas abigintthrough the accumulatorTest plan
npm test)Fixes #102