Do not initialize BalancerV2SwapInfoCache on unsupported chains [TKR-365]#472
Merged
kyu-c merged 2 commits intodevelopmentfrom May 10, 2022
Merged
Do not initialize BalancerV2SwapInfoCache on unsupported chains [TKR-365]#472kyu-c merged 2 commits intodevelopmentfrom
kyu-c merged 2 commits intodevelopmentfrom
Conversation
* Initializing BalancerV2SwapInfoCache on an unsupported chain causes a runtime error.
dekz
approved these changes
May 10, 2022
kyu-c
changed the title
dextracker
pushed a commit
that referenced
this pull request
May 13, 2022
] (#472) * Do not initialize BalancerV2SwapInfoCache on unsupported chains * Update CHANGELOG.json
idokleinman
added a commit
that referenced
this pull request
May 17, 2022
* Add BiSwap (as UniV2 clone) on BSC * changelog PR number * add BSW * remove BiSwap from transformer_utils * Do not initialize BalancerV2SwapInfoCache on unsupported chains [TKR-365] (#472) * Do not initialize BalancerV2SwapInfoCache on unsupported chains * Update CHANGELOG.json * Updated CHANGELOGS & MD docs * Publish - @0x/asset-swapper@16.57.3 * chore: Decomission SnowSwap [TKR-356] (#468) * Decomission SnowSwap * SnowSwap doesn't have much liquidity anymore (the largest pool has ~$50k) * Update CHANGELOG.json * Update CHANGELOG.json * chore: Offboard Swerve Finance and LinkSwap [TKR-356] (#469) * Offboard swerve * Update CHANGELOG.json * Offboard LinkSwap * Remove unused import * Fix CHANGELOG.json * chore: Offboard Eth2Dai [TKR-356] (#470) * Offboard Eth2Dai * Update CHANGELOG.json * feat: add IRfqClient (#467) * add message to changelog for #467 (#474) * Update saddle mainnet pools (#450) * Add saddle v2 pools * remove outdated pools * add two saddle meta pools * forgot changelog * remove saddle metapools * changelog update * Fix a lint issue (#475) * Updated CHANGELOGS & MD docs * Publish - @0x/asset-swapper@16.59.0 * Add BiSwap (as UniV2 clone) on BSC * rebase new changes for balv2, up changelog, quotes working * remove Biswap from transformer_utils once again Co-authored-by: Kyu <kyuhyun217@gmail.com> Co-authored-by: Github Actions <github-actions@github.com> Co-authored-by: phil-ociraptor <phil@0x.org> Co-authored-by: Cece Z <me@cecez.xyz> Co-authored-by: Noah Khamliche <noah@0xproject.com>
dextracker
pushed a commit
that referenced
this pull request
Jun 15, 2022
] (#472) * Do not initialize BalancerV2SwapInfoCache on unsupported chains * Update CHANGELOG.json
dextracker
added a commit
that referenced
this pull request
Jun 15, 2022
* Add BiSwap (as UniV2 clone) on BSC * changelog PR number * add BSW * remove BiSwap from transformer_utils * Do not initialize BalancerV2SwapInfoCache on unsupported chains [TKR-365] (#472) * Do not initialize BalancerV2SwapInfoCache on unsupported chains * Update CHANGELOG.json * Updated CHANGELOGS & MD docs * Publish - @0x/asset-swapper@16.57.3 * chore: Decomission SnowSwap [TKR-356] (#468) * Decomission SnowSwap * SnowSwap doesn't have much liquidity anymore (the largest pool has ~$50k) * Update CHANGELOG.json * Update CHANGELOG.json * chore: Offboard Swerve Finance and LinkSwap [TKR-356] (#469) * Offboard swerve * Update CHANGELOG.json * Offboard LinkSwap * Remove unused import * Fix CHANGELOG.json * chore: Offboard Eth2Dai [TKR-356] (#470) * Offboard Eth2Dai * Update CHANGELOG.json * feat: add IRfqClient (#467) * add message to changelog for #467 (#474) * Update saddle mainnet pools (#450) * Add saddle v2 pools * remove outdated pools * add two saddle meta pools * forgot changelog * remove saddle metapools * changelog update * Fix a lint issue (#475) * Updated CHANGELOGS & MD docs * Publish - @0x/asset-swapper@16.59.0 * Add BiSwap (as UniV2 clone) on BSC * rebase new changes for balv2, up changelog, quotes working * remove Biswap from transformer_utils once again Co-authored-by: Kyu <kyuhyun217@gmail.com> Co-authored-by: Github Actions <github-actions@github.com> Co-authored-by: phil-ociraptor <phil@0x.org> Co-authored-by: Cece Z <me@cecez.xyz> Co-authored-by: Noah Khamliche <noah@0xproject.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initializing
BalancerV2SwapInfoCacheon an unsupported chain causes a runtime error asBalancerSDKtries to read undefined properties.Testing instructions
Tested locally that this change prevents runtime error on a chain where Balancer V2 is not supported.
Types of changes
Checklist:
[WIP]if necessary.