[contract-addresses] Add ChainId type predicate#756
Merged
rhinodavid merged 1 commit intodevelopmentfrom Nov 2, 2023
Merged
Conversation
rhinodavid
commented
Oct 27, 2023
| @@ -1,42 +1,49 @@ | |||
| import addresses from '../addresses.json'; | |||
|
|
|||
| export interface ContractAddresses { | |||
rhinodavid
commented
Oct 27, 2023
| zrxVault: string; | ||
| } | ||
|
|
||
| export enum ChainId { |
rhinodavid
force-pushed
the
david/contract-chainid
branch
from
0ccd385 to
ac5e271
Compare
phil-ociraptor
approved these changes
Oct 27, 2023
dekz
approved these changes
Oct 30, 2023
kyu-c
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a handy-dandy type predicate for Chain ID.
And sort the types like we care about them.
Testing instructions
Batteries included!