feat: EIP1559 style gas price estimation #416
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/0x-eng/website/GFCH1G78fAgAqKLR9AQzb7WMUndv |
| key: fs.readFileSync('./server.key'), | ||
| cert: fs.readFileSync('./server.cert'), | ||
| }; | ||
| } |
There was a problem hiding this comment.
With SSL turned on for local dev the page won't even load in Chrome due to an invalid cert 🙈
There was a problem hiding this comment.
Is this because the cert is expired?
There was a problem hiding this comment.
I just checked. I didn't see the ./server.key or ./server.cert exist.
There was a problem hiding this comment.
yeah I don't have it either 😂 Previously you could just ignore the invalid config in Chrome but not anymore. I don't think https for local dev adds much value so might as well remove it 🙈
There was a problem hiding this comment.
Cool. Please let me know if you think you need it in the future, I think I can do something about it.
| "lint": "tslint --format stylish --project . 'ts/**/*.ts' 'ts/**/*.tsx'", | ||
| "fix": "yarn lint --fix", | ||
| "pre_push": "yarn lint:prettier && yarn lint && yarn test", | ||
| "pre_push": "yarn typecheck && yarn lint:prettier && yarn lint && yarn test", |
There was a problem hiding this comment.
actually checking types unveiled a few lingering TS type issues:feelsgood:
No description provided.