-
Notifications
You must be signed in to change notification settings - Fork 55
feat: EIP1559 style gas price estimation #416
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -147,25 +147,12 @@ module.exports = (_env, argv) => { | |
| disableHostCheck: true, | ||
| // Fixes assertion error | ||
| // Source: https://github.com/webpack/webpack-dev-server/issues/1491 | ||
| https: { | ||
| spdy: { | ||
| protocols: ['http/1.1'], | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| if (isDevEnvironment) { | ||
| config.mode = 'development'; | ||
| config.devtool = 'cheap-module-eval-source-map'; | ||
| // SSL certs | ||
| if (fs.existsSync('./server.cert') && fs.existsSync('./server.key')) { | ||
| config.devServer.https = { | ||
| ...config.devServer.https, | ||
| key: fs.readFileSync('./server.key'), | ||
| cert: fs.readFileSync('./server.cert'), | ||
| }; | ||
| } | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With SSL turned on for local dev the page won't even load in Chrome due to an invalid cert 🙈
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this because the cert is expired?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just checked. I didn't see the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah I don't have it either 😂 Previously you could just ignore the invalid config in Chrome but not anymore. I don't think https for local dev adds much value so might as well remove it 🙈
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cool. Please let me know if you think you need it in the future, I think I can do something about it. |
||
| } else { | ||
| config.mode = 'production'; | ||
| config.devtool = 'source-map'; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually checking types unveiled a few lingering TS type issues:feelsgood: