Fix StreamableHttpTransport JSON-RPC envelope handling#18
Merged
Conversation
…sult The StreamableHttpTransport::request method was passing the params directly to the server instead of wrapping them in a JSON-RPC envelope. It was also returning the full JSON-RPC response instead of extracting the result. Fixes: - Build proper JSON-RPC request with jsonrpc, method, params, and id - Extract result from JSON-RPC response envelope - Handle JSON-RPC errors by throwing TransportError
0xeb
force-pushed
the
fix/streamable-http-client
branch
from
292b8b1 to
cdb489a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The StreamableHttpTransport was passing params directly instead of wrapping them in a JSON-RPC envelope (
{"jsonrpc":"2.0","method":...,"params":...,"id":...}). It was also returning the full JSON-RPC response instead of extracting the result.This caused interop failures when C++ StreamableHttpTransport client connected to Python Streamable HTTP servers.
Test plan