feat: static curl build + POST streaming transport test#23
Merged
Conversation
Implements FASTMCPP_FETCH_CURL via FetchContent when POST streaming is enabled and curl isn't available. Also aligns README version/options wording.
- Prefer libcurl_static and avoid requiring a runtime DLL - Treat CURLE_PARTIAL_FILE as success for SSE-style POST streams
Link fetched curl statically, and add a build-time helper to copy the curl DLL next to executables when it exists.
Remove the post-build DLL copy helper; the FetchContent curl build is kept static so examples/tests don't require libcurl-d.dll.
When FASTMCPP_ENABLE_POST_STREAMING=ON and FASTMCPP_FETCH_CURL=ON, skip find_package() and build curl via FetchContent as a static library. Also gates the POST streaming demo test on TARGET CURL::libcurl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
cmake: fetch libcurl when requestedcmake: make fetched curl static + fix POST stream errorbuild(windows): avoid libcurl-d.dll loader errorsbuild: always avoid curl DLL dependencycmake: always fetch static curl when requestedtest(post-stream): add POST streaming transport testTest plan