Fix long path error 123 for copy/move/delete (#34)#35
Merged
Conversation
BuildScriptFromSnapshot only populated wide paths (SourceNameW/TargetNameW) when items had NameW set. ANSI-only items got no wide paths, so ANSI APIs failed with ERROR_INVALID_NAME (123) on paths exceeding MAX_PATH. Add else-if fallback at all 5 locations: widen the ANSI name and pass it through SetSourceNameW/SetTargetNameW which applies \?\ prefix for long paths. Also fix the delete fallback which used BuildWidePath (no prefix) instead of SetSourceNameW. Remove now-unused BuildWidePath helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ERROR_INVALID_NAME(error 123) when copying/moving/deleting files with paths >260 chars and ANSI-only item namesBuildScriptFromSnapshotonly populated wide paths (SourceNameW/TargetNameW) whenitem.NameWwas set — ANSI-only items got no wide paths, so the worker fell back to ANSI APIs which fail on long pathselse iffallback at all 5 affected locations: widen the ANSI name and pass throughSetSourceNameW/SetTargetNameWwhich applies\?\prefixBuildWidePath()(no\?\prefix) instead ofSetSourceNameWTest plan
gtest_longpath_copymove(all passing)\?\prefix logic (short path, long path, UNC path)Closes #34