Fix HTML entity decoding order #2634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 23, 2026
youngkidwarrior
force-pushed
the
fix-html-entity-decoding-order
branch
from
63131db to
540ef88
Compare
youngkidwarrior
force-pushed
the
refactor-proxy-image-url-validation
branch
2 times, most recently
from
6dd283a to
b2890a3
Compare
youngkidwarrior
force-pushed
the
fix-html-entity-decoding-order
branch
2 times, most recently
from
9309c0f to
5f98e1d
Compare
youngkidwarrior
force-pushed
the
refactor-proxy-image-url-validation
branch
2 times, most recently
from
fa680c4 to
b8c78e8
Compare
youngkidwarrior
force-pushed
the
fix-html-entity-decoding-order
branch
from
5f98e1d to
9fa77b3
Compare
youngkidwarrior
force-pushed
the
refactor-proxy-image-url-validation
branch
from
b8c78e8 to
b5fbabd
Compare
youngkidwarrior
force-pushed
the
fix-html-entity-decoding-order
branch
from
9fa77b3 to
8b5bd5c
Compare
youngkidwarrior
force-pushed
the
refactor-proxy-image-url-validation
branch
from
b5fbabd to
d44d87a
Compare
youngkidwarrior
force-pushed
the
fix-html-entity-decoding-order
branch
from
8b5bd5c to
94af36d
Compare
youngkidwarrior
force-pushed
the
refactor-proxy-image-url-validation
branch
2 times, most recently
from
151c251 to
c65578a
Compare
youngkidwarrior
force-pushed
the
fix-html-entity-decoding-order
branch
from
94af36d to
90bcba8
Compare
Collaborator
Author
Merge activity
|
youngkidwarrior
changed the base branch from
refactor-proxy-image-url-validation
to
graphite-base/2634
Fixed HTML entity decoding order in `decodeHtmlEntities()` to decode `&` last only once, preventing double-unescaping of sequences like `&lt;`. Co-Authored-By: Warp <agent@warp.dev>
youngkidwarrior
force-pushed
the
fix-html-entity-decoding-order
branch
from
90bcba8 to
0d5670d
Compare
|
Vercel Unique URL: https://sendapp-hspn8ivvz-0xsend.vercel.app |
Playwright Report
Summary
Suites✅ account-sendtag-add.onboarded.spec.ts (5/5 passed)can visit add sendtags page
can add a pending tag
cannot add an invalid tag name
cannot add more than 5 tags
cannot confirm a tag without paying
❌ account-sendtag-checkout.onboarded.spec.ts (1/3 passed)can confirm a tag
can refer a tag
can refer multiple tags in separate transactions
✅ account-settings-backup.onboarded.spec.ts (2/2 passed)can backup account
can remove a signer
✅ account.logged-in.spec.ts (2/2 passed)can visit account page
can update profile
❌ activity.onboarded.spec.ts (0/1 passed)can visit activity page and see correct activity feed
✅ contacts.onboarded.spec.ts (0/0 passed)✅ earn.onboarded.spec.ts (0/0 passed)✅ home.onboarded.spec.ts (1/1 passed)can visit token detail page
✅ leaderboard.logged-in.spec.ts (0/0 passed)can visit leaderboard page
✅ onboarding.logged-in.spec.ts (1/1 passed)can visit onboarding page
✅ profile-external-address.anon.spec.ts (0/0 passed)✅ profile-external-address.onboarded.spec.ts (0/0 passed)❌ profile.anon.spec.ts (1/2 passed)anon user can visit public profile
anon user cannot visit private profile
❌ profile.logged-in.spec.ts (0/1 passed)logged in user needs onboarding before visiting profile
❌ profile.onboarded.spec.ts (1/4 passed)can visit other user profile and send by tag
can visit my own profile
can visit private profile
can view activities between another profile
❌ send-token-upgrade.onboarded.spec.ts (0/1 passed)can upgrade their Send Token V0 to Send Token V1
❌ send.onboarded.spec.ts (0/13 passed)can send USDC starting from profile page
can send USDC using tag starting from home page
can send USDC using sendid starting from home page
can send USDC using address starting from home page
can send SEND starting from profile page
can send SEND using tag starting from home page
can send SEND using sendid starting from home page
can send SEND using address starting from home page
can send ETH starting from profile page
can send ETH using tag starting from home page
can send ETH using sendid starting from home page
can send ETH using address starting from home page
cannot send below minimum amount for SEND token
❌ sendtag-happy-path.onboarded.spec.ts (0/1 passed)sendtag complete happy path - create, confirm, and change main tag
sendtag main tag succession - auto-assigns new main when current is deleted
✅ sign-in.anon.spec.ts (3/3 passed)redirect on sign-in
redirect to send page on sign-in with recipient params
old user can login using phone number
✅ sign-up.anon.spec.ts (2/2 passed)can sign up
country code is selected based on geoip
❌ swap.onboarded.spec.ts (2/5 passed)can swap USDC for SEND
can swap USDC for ETH
can refresh swap form and preserve filled data
can't access form page without accepting risk dialog
can't access summary page without filling swap form
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed HTML entity decoding order in
decodeHtmlEntities()to decode&last only once, preventing double-unescaping of sequences like&lt;.Co-Authored-By: Warp agent@warp.dev