-
Notifications
You must be signed in to change notification settings - Fork 18
Home Bottom Sheet for mobile #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2cd9fdf to
86edab5
Compare
22122c8 to
e73c15e
Compare
86edab5 to
04cdfbb
Compare
e73c15e to
c1afdd7
Compare
0xBigBoss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the idea that we may have multiple navs? Else I am kinda confused by this implementation.
Isn't there a way to watch for path changes in solito? Couldn't we just turn this prop into component state then? I feel like having each link set the param is kinda an antipattern and isn't required.
other than that, this PR looks spicy and really close.
|
@0xBigBoss the original version of this PR used context to achieve the open and close functionality. The nice thing about using query params is that
Where I think this falls short is that the state of the navbar can be adjusted via the url, so we will need some sort of gating logic at the component level if there are any navbars that require auth So we could use context, or opt in for a global state manager like mobX, but I think url state is the simplest and provides the most flexibility |
c1afdd7 to
ebb01ae
Compare
04cdfbb to
22d33a7
Compare
ebb01ae to
36df3e7
Compare
22d33a7 to
55e2b94
Compare
36df3e7 to
5e0f7c5
Compare
713add2 to
1b46da2
Compare
f21a7c9 to
4e1bb0f
Compare
1b46da2 to
41f0638
Compare
- Fix #50 (SSRF): Add allowlist validation in proxy-image.ts (only static.klipy.com) - Fix #51 (URL sanitization): Use URL.hostname instead of substring check - Fix #52, #53, #54 (ReDoS): Replace unsafe regex patterns in LinkPreview.tsx - Fix #49 (double-escaping): Improve HTML entity decode in linkPreview router - Fix #48 (permissions): Add explicit permissions block to deploy-dev.yml Co-Authored-By: Warp <agent@warp.dev>
Adds logic for bottom sheet on mobile. Uses url state instead of context
Not 100% happy with the naming of everything, probably will take some time to rethink
This PR depends on #28 and #41