Feature/fee options #116
Merged
Feature/fee options #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s request. Some refactoring to demo pages. Fixed a few namespaces
…ool specifying if the user has enough of a particular token to pay the fee
…at it sends the transaction with the first FeeOption in the user's wallet. This involved also updating the IWallet interface and implementation
taylanpince
previously approved these changes
May 23, 2024
taylanpince
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added FeeOptions support for transactions. This is useful in some cases where you choose not to sponsor user's transactions. For convenience, the SDK's implementation of FeeOptions will automatically use the Indexer to determine which of the returned FeeOptions the user has in their wallet and will decorate the response with a bool flags for each FeeOption indicating which, if any, FeeOptions the user can afford.
Documentation update: 0xsequence/docs#114
With this PR, I've included a basic demo page (imported via Samples as "Demo Scene") that allows you to send a basic transfer (just like the the "Send Transfer" page in the same scene) except it will first fetch the FeeOptions from the WaaS API then will send the transfer using the first FeeOption the user can afford (if possible, else it logs an error). See video:
FeeOptions.mov