Tests/end to end setup#150
Merged
colezemind merged 21 commits intomasterfrom Oct 17, 2024
Merged
Conversation
…e house for our tests without requiring our users to import them into their project
…e resulting in warnings during testing
…, Removed a warning that wasn't a real warning
BellringerQuinn
commented
Sep 20, 2024
Contributor
Author
BellringerQuinn
left a comment
BellringerQuinn
left a comment
There was a problem hiding this comment.
Thanks for the improvements here Calvin. Looks good, but I can't approve officially since I created the PR
…Common - here we will house any constants needed
…age will cause the page to be omitted from the JSON as opposed to being included with default values - this resolves a bug where we got no responses.
Tests/indexer
…default page was being provided instead of omitted causing fetching errors
…FSeqGetTokenSuppliesMapArgs JSON - it was missing commas between key value pairs in the token map array and was throwing errors on request. Added constructor to FSeqTokenList struct.
Closed
Tests/indexer
colezemind
approved these changes
Oct 17, 2024
Contributor
colezemind
left a comment
colezemind
left a comment
There was a problem hiding this comment.
Changes look good, current setup tests all run without issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@CalvinKork I put together a PoC automated end-to-end test for the Indexer
The test is inside a separate plugin (SequenceTests) as recommended in this doc. Let me know if you have any thoughts or concerns with this approach.
To run the tests (Mac instructions)
PC instructions may differ slightly - if so, this doc is hopefully up to date https://dev.epicgames.com/documentation/en-us/unreal-engine/automation-system-in-unreal-engine
I also found these https://github.com/0xsequence/sequence-unreal/tree/master/Plugins/SequencePlugin/Source/SequencePlugin/Private/Tests
Some of these tests are available in the automated testing framework under "Public" - we may want to consider moving them
Some of these tests are not available in the automated testing framework but we can likely adapt/modify them to fit; though they may have other purposes that I don't have the context for
Thoughts?