Marketplace Collectibles Intent#171
Merged
caballoninja merged 9 commits intomasterfrom Oct 29, 2024
Merged
Conversation
Included marketplace directories with new Marketplace manager file and get collectibles intent
Removed excessive logs in the parsing of the response for getcollectible listings
Contributor
|
To future reviewers: Overall, the code looks good to me; left a few comments (only the header is a blocker for me - easy fix). Ideally, I'd love to get another set of eyes on this I have not tested @caballoninja's implementation in Unreal only reviewed the code |
Updated access key header into consistent formatting -> X-Access-Key
Corrected and unCommented Marketplace Enum types and helper functions for conversions.
forgot to ctrl+s on this one
Updated default values for Page to be included or not depending on SeqMarketplacePage.ContainsData()
BellringerQuinn
previously approved these changes
Oct 25, 2024
removed sequenceapi/sequencewalletbp marketplace calls, and ac_sequencepawn component marketplace calls
BellringerQuinn
approved these changes
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included marketplace directories with new Marketplace manager file and get collectibles intent. included structs and enums to build args and store response.