Created Contract Wrappers#183
Conversation
Created Contract wrappers for erc20, erc721, erc1155, with grantrole, mint and burn. Also, erc721Sale, erc1155Sale with "PrimaryPurchase"/mint
small cleanup and renaming
There was a problem hiding this comment.
This is great! Thanks @caballoninja!
A couple of thoughts:
- These are likely to be very high-touch wrappers; we should make sure to add them to our docs (including some sample code)
- Similarly, as these are high-touch points; we should add some tests for them (@ZemindJan @caballoninja would you mind reviewing #172 when you get a chance)
|
Also, can we add constructors to the contract wrappers to require the contract address? It seems like every method call relies upon that info so I think it would be best for us to force it get set |
revisions on constructors and fixes
|
What was the update on the GetPaymentToken and GetSaleDetails functions for the sale contract wrappers? Right now theyre removed, or shall we change them to return RawTransactions instead? |
(wouldnt let me answer directly) my idea is to revisit the contract call to make it blueprintable, but if not yes, i will make them rawTx |
Included contractcalls
|
@andygruening added back the contract calls |
BellringerQuinn
left a comment
BellringerQuinn
left a comment
There was a problem hiding this comment.
Overall looks good to me. I'll let @andygruening approve as he has more context with this ticket.
Question for you @caballoninja - I noticed that a lot of the contracts have an FString Data field. What is this for?
INcluded make approve transaction for erc20,721,1155
andygruening
left a comment
andygruening
left a comment
There was a problem hiding this comment.
Great thanks, looks toptop!
3 participants
Created Contract wrappers for erc20, erc721, erc1155, with grantrole, mint and burn. Also, erc721Sale, erc1155Sale with "PrimaryPurchase"/mint