Updated intent.gen without webrpc types, errors exported from authenticator.gen#560
Merged
Updated intent.gen without webrpc types, errors exported from authenticator.gen#560
Conversation
tolgahan-arikan
changed the title
attente
reviewed
Aug 7, 2024
| Session, | ||
| WebrpcEndpointError, | ||
| WebrpcError | ||
| } from './clients/authenticator.gen' |
Contributor
There was a problem hiding this comment.
Is this change necessary? What uses WebrpcEndpointError and WebrpcError in this file?
Contributor
Author
There was a problem hiding this comment.
yep you are right, I think I forgot to remove after testing
attente
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were exporting error types from intent.gen instead of authenticator.gen, which caused issues when trying to check the type of errors, for example
if (error instanceof WebrpcEndpointError)was not returning true while error was an instance of WebrpcEndpointError, but from authenticator.gen.