Skip to content

Add pending wallet selection flow#13

Merged
tolgahan-arikan merged 10 commits into
masterfrom
update-wallet-selection-flow
May 21, 2026
Merged

Add pending wallet selection flow#13
tolgahan-arikan merged 10 commits into
masterfrom
update-wallet-selection-flow

Conversation

@tolgahan-arikan
Copy link
Copy Markdown
Collaborator

@tolgahan-arikan tolgahan-arikan commented May 20, 2026

Summary

  • add session-bound PendingWalletSelection manual auth flow for email and OIDC redirect auth; the result carries walletType, filtered wallets, credential, selectWallet, and createAndSelectWallet
  • bind pending wallet selection to the signer/auth session and guard stale, reused, and concurrent selection actions before wallet API requests
  • make pending selection behavior match the requested wallet type: filter wallets locally, validate selected wallet membership before UseWallet, and create wallets with the auth-requested type
  • require public wallet.useWallet and wallet.createWallet to start from an active wallet session; manual auth must complete through PendingWalletSelection
  • expose wallet.getIdToken as the public wrapper around generated GetIDToken, with docs, type tests, unit coverage, and a React example entry under Other operations
  • harden email auth completion so the same attempt is single-flight/idempotent, stale attempts cannot activate or persist pending state, retryable failures can retry, and consumed commitments clear the active attempt
  • tighten SDK internals with typed wallet/indexer operation labels and remove unneeded root exports: defaultGoogleClientId, defaultRelayRedirectUri, SigningAlgorithm, and OmsSdkErrorParams
  • update API docs, README, type tests, wallet/OIDC/error coverage, and the React example manual-selection UI/layout

Verification

  • pnpm exec vitest run tests/walletSession.test.ts tests/walletErrors.test.ts tests/indexerClient.test.ts
  • pnpm exec vitest run tests/walletSigning.test.ts
  • pnpm test:types
  • pnpm exec tsc --noEmit
  • pnpm test
  • pnpm build
  • pnpm build:example
  • pnpm build:node-example
  • git diff --check
  • React example dev server verified at http://127.0.0.1:5173/

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a51d3c5ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/clients/walletClient.ts
@tolgahan-arikan tolgahan-arikan merged commit fd93c66 into master May 21, 2026
1 check passed
@tolgahan-arikan tolgahan-arikan deleted the update-wallet-selection-flow branch May 21, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant