Apply OMS design system to example apps#30
Conversation
- Restyle react, wagmi, and trails-actions examples with oms-sdk-design-system tokens - Centralize tokens in examples/shared/oms-tokens.css; each example imports it - Load Fustat/Inter/Geist Mono fonts in each example - Document the styling convention in AGENTS.md (rules + Maintenance Matrix)
|
Claude finished @tolgahan-arikan's task —— View job Reviewing PR: Apply OMS design system to example apps
Analysis complete - This PR contains only visual styling changes to example apps. No SDK source code under Review Findings✅ SDK Behavior: No changes to core SDK functionality - only example app styling updated ✅ No Committed Secrets: All environment variables remain in ✅ TypeScript & Imports: No TypeScript changes or import modifications in this PR 🔧 Styling Issue Identified: The Codex review correctly identified a hover color accessibility issue 🚨 Critical Issue: Button Hover AccessibilityLocation: Problem: The generic Evidence:
Solution Already Implemented: The React example correctly addresses this with specific overrides: .fee-option:hover:not(:disabled),
.wallet-option:hover:not(:disabled) {
background: var(--oms-slate-200);
}Wagmi & Trails-Actions: Similar pattern exists - ✅ Positive Observations
📋 Verification Checklist
🎯 RecommendationAPPROVE - This is a well-architected styling update that properly implements the OMS design system. The hover color accessibility issue flagged by Codex is already correctly handled through specific CSS overrides. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 830acd245e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
.fee-option/.wallet-option are light-background buttons; the generic button:hover/:active darkened them while text stayed dark. Add option- specific hover (slate-200) and active (purple-100) overrides.
Summary
Restyles all three browser example apps (
react,wagmi,trails-actions) to align with theoms-sdk-design-systemtokens. Purely visual — no markup, copy, sections, or functionality changed.#F6F6FC, white surfaces, ink#141635, brand purple#670DE5(replacing the old blue accent), slate borders.slate950→ hoverslate800→ activepurple700; outlined secondaries withpurple100active fill; purple focus ring).24, tools16, inputs/buttons12, badges16) and thergba(103,13,229,0.15)input focus glow.index.html..burn-buttonfire-effect animation is preserved (its gradient is an intentional decorative exception, not a token).Staying aligned going forward
examples/shared/oms-tokens.css, imported by each example'sstyles.cssvia@import. The three apps can no longer drift, and a token change is a one-file edit.AGENTS.mdgains an Example App Styling section + a Maintenance Matrix row: use--oms-*variables, never hardcode hex/radius in per-app CSS, and sync the shared file fromoms-sdk-design-systemupstream.Verification
pnpm build:example,pnpm build:wagmi-example,pnpm build:trails-actions-exampleall build clean.@importinlines into each production CSS bundle (--oms-brand+Fustatpresent).