refactoring: ♻️ replace call with __call__ in asfunction#277
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the asfunction decorator to use the standard __call__ method instead of a custom call method, simplifying the API and improving consistency with Python conventions.
- Replaced custom
AsFunctionCallableprotocol with standardCallabletype - Updated all method calls from
callto__call__ - Simplified type definitions and removed unnecessary protocol abstractions
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| injection/_core/asfunction.py | Removes custom protocol, updates type hints, and changes method calls to use __call__ |
| tests/core/test_asfunction.py | Updates test classes to use __call__ instead of call method |
| documentation/integrations/unlisted-framework.md | Updates documentation examples to show __call__ usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.