Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for conditionally filtering NoneType when standardizing type hints in the dependency injection system. The main purpose is to allow more fine-grained control over how NoneType is handled when registering types for injection, particularly useful for mapped scopes with optional fields.
- Added
ignore_none_typeparameter to the type standardization pipeline - Refactored the
Locator.updatemethod to use a new__reduce_classeshelper instead of mutating state - Updated
MappedScopedescriptor to ignoreNoneTypewhen reserving scoped slots for optional fields
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| injection/_core/common/type.py | Added ignore_none_type parameter to standardize_types to conditionally filter NoneType, with recursive propagation |
| injection/_core/module.py | Added ignore_none_type support throughout the injection pipeline and refactored type preprocessing to avoid mutation |
| injection/_core/descriptors.py | Updated MappedScope to pass ignore_none_type=True when generating keys for type hints |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.