Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the ScopedInjectable class to use SlotKey instances as cache keys instead of using the injectable instance itself (self). This architectural improvement better separates concerns by decoupling the cache key from the injectable instance.
Key Changes
- Added a
key: SlotKey[T]field toScopedInjectablefor use as the cache key - Updated all cache-related method calls to use
self.keyinstead ofself - Updated type signatures in
scope.pyto properly reflect thatSlotKey[Any]is the cache key type - Updated dependency versions:
secretstorage(3.4.1 → 3.5.0) andtype-analyzer(0.1.0 → 0.1.1)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| uv.lock | Updates secretstorage from 3.4.1 to 3.5.0 and type-analyzer from 0.1.0 to 0.1.1 |
| injection/_core/scope.py | Updates type signatures for in_scope_cache, remove_scoped_values, and cache fields to use SlotKey[Any] as the key type |
| injection/_core/injectables.py | Adds key: SlotKey[T] field to ScopedInjectable and updates all cache operations to use self.key instead of self |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.