Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables bidirectional dependencies between modules by implementing cycle detection mechanisms. Previously, creating circular module dependencies would cause infinite loops during event propagation and broker iteration. The implementation adds duplicate detection for event propagation and uses a visited set to prevent infinite recursion when iterating through module hierarchies.
Key Changes
- Added cycle detection in event propagation through the
is_duplicateproperty onModuleEventProxy - Modified
_iter_brokersto use a visited set, preventing infinite recursion in bidirectional module relationships - Changed initialization order in
ProfileLoader.__init_subsets_forto mark modules as initialized before processing their subsets
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/loaders/test_profile_loader.py |
Adds test case verifying bidirectional profile loading works correctly |
tests/core/test_module.py |
Adds test case confirming bidirectional module usage generates expected events |
injection/loaders.py |
Marks modules as initialized before processing subsets to prevent infinite recursion in circular dependencies |
injection/_core/module.py |
Implements core cycle detection: adds is_duplicate, origin, and proxy_history properties to ModuleEventProxy; modifies _iter_brokers to track visited modules; updates on_event to return None for duplicates; enhances UnlockCalled event with module reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.