Skip to content

feat: add in-repo automated issue creation workflow#389

Merged
phantom5099 merged 3 commits intomainfrom
xgopilot/issue-377-1776758171
Apr 22, 2026
Merged

feat: add in-repo automated issue creation workflow#389
phantom5099 merged 3 commits intomainfrom
xgopilot/issue-377-1776758171

Conversation

@fennoai
Copy link
Copy Markdown

@fennoai fennoai Bot commented Apr 21, 2026

Requested by @fanfeilong

This PR adds a repository-local automation entry for creating GitHub issues directly from the repo workspace.

Summary

Verification

  • ./scripts/create_issue.sh --help
  • go test ./...
  • go build ./...

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: fanfeilong <2046098+fanfeilong@users.noreply.github.com>
Copy link
Copy Markdown
Author

@fennoai fennoai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed four-pass review (code quality, performance, security, documentation accuracy) on changed files.

One concise improvement suggestion below.

Comment thread scripts/create_issue.sh
fi
}
trap cleanup EXIT INT TERM

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--labels currently splits on commas but keeps surrounding whitespace, so input like --labels "bug, priority-high" sends the second label as " priority-high" and can fail to match expected labels. Consider trimming each label token before appending --label.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xgopilot 修复

Copy link
Copy Markdown
Author

@fennoai fennoai Bot Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

处理结果

已按评论要求修复 scripts/create_issue.sh 的标签空白问题:

  • 新增 trim_label(),对 --labels 逗号分割后的每个标签做首尾空白裁剪。
  • 仅在裁剪后标签非空时追加 --label,避免传入空标签。

变更

  • 提交: adc6a47
  • 文件: scripts/create_issue.sh

验证

  • ./scripts/create_issue.sh --help
  • go test ./...
  • go build ./...

未处理项:无。

View job run

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

xgopilot and others added 2 commits April 21, 2026 11:33
Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: fanfeilong <2046098+fanfeilong@users.noreply.github.com>
Generated with [codeagent](https://github.com/qbox/codeagent)

Co-authored-by: phantom5099 <245659304+phantom5099@users.noreply.github.com>
@phantom5099
Copy link
Copy Markdown
Collaborator

@xgopilot 审查当前PR是否可以通过

@fennoai
Copy link
Copy Markdown
Author

fennoai Bot commented Apr 22, 2026

审查结论

当前 PR 不建议通过,存在 1 个需修复的问题。

Findings

  1. 中风险:install-skills 默认会在仓库内生成未被统一忽略的目录,容易把本地工具产物误提交到 PR。
    • 变更位置:scripts/install_skills.sh:13(默认目标包含 .codex/skills.claude/skills.cursor/skills.windsurf/skills)与 README.md:198-203(文档明确这些目录会被写入)。
    • 现状:.gitignore 目前只忽略了 .claude/(见 .gitignore:40),没有忽略 .codex/.cursor/.windsurf/
    • 影响:执行 make install-skills 后会在工作区产生可被 Git 跟踪的本地目录,后续提交时容易混入无关文件,违反仓库“本地运行/工具数据默认不入库”的约束。
    • 建议:补充 .gitignore.codex/.cursor/.windsurf/(至少其 skills 子目录)的忽略规则,或将默认安装目标改到仓库外路径。

备注

本轮未做代码修改;仅基于 origin/main...HEAD 进行了审查与脚本基础验证。

View job run

@phantom5099 phantom5099 merged commit 60a0cce into main Apr 22, 2026
2 checks passed
@fennoai fennoai Bot deleted the xgopilot/issue-377-1776758171 branch April 22, 2026 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants