Skip to content

fix(www): 修正首页安装区块布局、补充缺失文档内容并隐藏全局滚动条#425

Merged
pionxe merged 4 commits into1024XEngineer:mainfrom
Yumiue:fix/www-content-sync-main
Apr 23, 2026
Merged

fix(www): 修正首页安装区块布局、补充缺失文档内容并隐藏全局滚动条#425
pionxe merged 4 commits into1024XEngineer:mainfrom
Yumiue:fix/www-content-sync-main

Conversation

@Yumiue
Copy link
Copy Markdown
Collaborator

@Yumiue Yumiue commented Apr 23, 2026

改动概要

首页安装区块改造

  • 将首页 Quick Start 区块从三列步骤式改为两列并列安装方式(安装脚本 / 源码运行)
  • 第 1 列补充安装后启动命令
    eocode
  • API Key 配置从安装卡片中移出,改为常用入口独立卡片

文案与事实对齐(按代码与 README 校准)

  • 修正首页 features 中不准确的 Ollama 描述,改为当前真实内置 Provider:openai、gemini、openll、qiniu
  • guide/install.md 补充安装脚本实际行为:
    • macOS / Linux 安装到 /usr/local/bin/
    • Windows 安装到 %LOCALAPPDATA%\NeoCode 并更新 PATH
  • guide/memo-skills.md 补充仓库内置 Skills 与安装方式(make install-skills)
  • guide/quick-start.md 增加升级与版本检查链接

英文站补充

  • en/docs/index.md 扩写为更完整导航(阅读顺序 + 直接入口 + 参考文档)
  • en/index.md 文案与中文站事实保持一致

样式调整

  • 全局隐藏滚动条(WebKit / Firefox / IE)

- 首页 Quick Start 从三列步骤式改为两列并列安装方式(安装脚本 / 源码运行),移除不存在的 Ollama 引用
- API Key 配置移至下方常用入口卡片
- 补充安装后启动命令 neocode 的提示
- 补充安装脚本实际行为说明(下载路径、PATH 配置)
- 补充仓库内置 Skills(make install-skills)的说明
- quick-start.md 增加升级与版本检查链接
- 扩写英文站 en/docs/index.md 导航结构
- 全局隐藏滚动条(WebKit + Firefox + IE)
Copy link
Copy Markdown

@fennoai fennoai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed 4 review passes (code quality, performance, security, docs accuracy). I found 2 noteworthy issues in the changed lines.

  • Code quality: one newly introduced unused constant and now-unused credential snippets left in component scope.
  • UX/accessibility risk: global scrollbar hiding on html/body removes a key scroll affordance across the docs site.

No performance or security regressions were identified in this diff.


const installUnix = 'curl -fsSL https://raw.githubusercontent.com/1024XEngineer/neo-code/main/scripts/install.sh | bash'
const installWindows = 'irm https://raw.githubusercontent.com/1024XEngineer/neo-code/main/scripts/install.ps1 | iex'
const runBinary = `neocode`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runBinary is introduced but never used, and after removing the credentials card this component now also keeps unused env snippet constants in script scope. Please remove or rewire these constants to avoid dead code and lint noise.

Comment thread www/.vitepress/theme/custom.css Outdated
@@ -1,3 +1,14 @@
html,
body {
scrollbar-width: none;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiding scrollbars globally on html/body is a UX/accessibility regression: users lose a core scroll affordance and page-length cue. Consider limiting this style to specific decorative containers instead of the whole document.

@Yumiue
Copy link
Copy Markdown
Collaborator Author

Yumiue commented Apr 23, 2026

/simplify

@fennoai
Copy link
Copy Markdown

fennoai Bot commented Apr 23, 2026

完成情况

已按你的要求完成:读取历史评论并处理可修复项、调用 code-simplifier 做简化、提交并推送到当前 PR 分支。

本次已落地内容:

  • 修复 review 指出的死代码问题:移除 www/.vitepress/theme/components/QuickStartCards.vue 中未使用常量。
  • 修复可访问性回归:移除 www/.vitepress/theme/custom.csshtml/body 的全局隐藏滚动条规则。
  • 使用 code-simplifier 对改动做进一步简化并落地:
    • QuickStartCards.vue 合并中英文重复模板为数据驱动渲染。
    • custom.css 使用 :is(...) 收敛等价重复选择器,保持行为不变。
  • 已推送到分支:Yumiue:fix/www-content-sync-main

提交信息:

  • 6678e41 fix(www): resolve review issues and simplify quickstart/docs styles

未完成项:

  • 未能在当前环境完成站点构建校验:pnpm 不存在,且 npm run docs:build 因缺少 vitepress 依赖失败。

View job run

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@pionxe pionxe merged commit f658fd7 into 1024XEngineer:main Apr 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants