fix(tui): render thumb-only transcript scrollbar#437
Merged
phantom5099 merged 2 commits into1024XEngineer:mainfrom Apr 24, 2026
Merged
fix(tui): render thumb-only transcript scrollbar#437phantom5099 merged 2 commits into1024XEngineer:mainfrom
phantom5099 merged 2 commits into1024XEngineer:mainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
| func (a App) renderTranscriptWithScrollbar(totalWidth int, content string) string { | ||
| scrollbarWidth := a.transcriptScrollbarWidth(totalWidth) | ||
| if scrollbarWidth <= 0 { | ||
| if scrollbarWidth <= 0 || a.transcriptMaxOffset() <= 0 { |
There was a problem hiding this comment.
renderTranscriptWithScrollbar 新增了 a.transcriptMaxOffset() <= 0 的早返回逻辑，但当前测试主要覆盖了“宽度过窄不渲染滚动条”和“可滚动时渲染 thumb”，没有直接覆盖“宽度充足但内容不可滚动时不渲染滚动条”的新分支。建议补一个回归用例，避免后续改动把这一行为回退。
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.