fix(runtime):修复热切换问题#440
Conversation
|
@phantom5099 is attempting to deploy a commit to the pionxe's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
| if ctx != nil && ctx.Err() != nil { | ||
| return s.configManager.Get(), nil | ||
| } | ||
| return s.configManager.Load(context.Background()) |
There was a problem hiding this comment.
configManager.Load 被强制用 context.Background() 调用,会丢失上层 Run/Compact 的取消与超时语义。结果是:当配置文件 I/O 或解析卡住时,运行任务即使已取消也可能继续阻塞在这里。建议改为透传 ctx(必要时仅在 ctx == nil 时回退到 context.Background()),保证运行链路可及时响应取消。
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
/code 修复review的问题,并且提高测试覆盖率 |
完成情况已按你的要求修复 review 问题并补充覆盖率,代码已推送到当前 PR 分支 变更摘要
测试结果
提交信息
|
Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: phantom5099 <245659304+phantom5099@users.noreply.github.com>
问题
切换供应商时发现切换失效,实际上还是使用旧供应商