Skip to content

fix: 解决提交pr也触发cloudflare推送,但没有Token触发失败的问题!#445

Merged
pionxe merged 5 commits into1024XEngineer:mainfrom
pionxe:main
Apr 24, 2026
Merged

fix: 解决提交pr也触发cloudflare推送,但没有Token触发失败的问题!#445
pionxe merged 5 commits into1024XEngineer:mainfrom
pionxe:main

Conversation

@pionxe
Copy link
Copy Markdown
Collaborator

@pionxe pionxe commented Apr 24, 2026

No description provided.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Copy link
Copy Markdown

@fennoai fennoai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focused review completed across code quality, performance, security, and documentation accuracy. I found two noteworthy issues in the new PR preview deployment workflow.

with:
apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
projectName: 'neocode-docs'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow_run jobs run in the default-branch context. Without an explicit branch input here, this deployment can be attributed to the wrong branch (potentially main) instead of the PR branch, which risks promoting PR artifacts as production deployments. Please set branch explicitly (for example from github.event.workflow_run.head_branch) and keep preview deployments isolated from production branch semantics.

types:
- completed

jobs:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job uses repository secrets but does not declare explicit permissions. Relying on repository defaults can grant broader GITHUB_TOKEN scope than needed. Add least-privilege permissions (for example actions: read, contents: read, and only additional scopes strictly required by the deploy step).

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@pionxe pionxe merged commit 09cf047 into 1024XEngineer:main Apr 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant