fix: terminate final-acceptance loop when completion gate is blocked#448
Merged
phantom5099 merged 1 commit into1024XEngineer:mainfrom Apr 24, 2026
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
| @@ -24,66 +24,66 @@ func NewEngine(policy AcceptancePolicy) *Engine { | |||
|
|
|||
There was a problem hiding this comment.
已逐项检查该处及相关分支流转,当前实现与测试覆盖能够支撑本次修复目标,暂无可行动问题。
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
当 completion gate 未通过时,acceptance engine 会立即返回 continue,导致后续 no-progress/max-turn/retry 收敛逻辑失效,运行可能长期空转(持续注入 continue reminder)。
变更
internal/runtime/acceptance/engine.go:internal/runtime/acceptance/engine_test.gointernal/runtime/final_acceptance_test.go验证
go test ./internal/runtime/acceptance ./internal/runtime -run "TestEngineEvaluateFinal|TestBeforeAcceptFinalDecisionPaths"✅go test ./...internal/gateway/launcher(绝对路径断言)internal/tui/core/app(TempDir 清理)