Skip to content

修复一个系统信息被错误展示给用户bug#628

Merged
Yumiue merged 7 commits into
1024XEngineer:mainfrom
phantom5099:main
May 11, 2026
Merged

修复一个系统信息被错误展示给用户bug#628
Yumiue merged 7 commits into
1024XEngineer:mainfrom
phantom5099:main

Conversation

@phantom5099
Copy link
Copy Markdown
Collaborator

No description provided.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Copy link
Copy Markdown

@fennoai fennoai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in four passes. I found 1 functional regression in the changed hunk; no additional noteworthy performance, security, or documentation issues.

Comment thread internal/tui/core/app/update.go Outdated
}
message := a.activeMessages[idx]
// 跳过 system 角色消息,避免系统提醒被渲染为 assistant 回复
if message.Role == roleSystem {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

message.Role == roleSystem is broader than the bug you are trying to suppress. system messages are also used for transcript inline logs and decision/verify/tool entries, so this change removes the content that should become visible after expanding a folded process segment. Existing tests already cover this regression (TestTranscriptEnterTogglesFoldedProcessVisibility and TestTranscriptMouseClickFoldPlaceholderExpandsProcess both fail with this patch). Filter only the unintended system notice shape here instead of dropping every system message.

@phantom5099
Copy link
Copy Markdown
Collaborator Author

@xgopilot 给我修复编译错误问题

@fennoai
Copy link
Copy Markdown

fennoai Bot commented May 11, 2026

已完成

已把修复提交并推送到当前 PR 分支 phantom5099/main,提交为 a3dbb277

本次处理内容:

  • 将 transcript 中对 system 消息的过滤收窄为“仅隐藏普通系统提示”,保留 inline log,避免过程折叠/展开内容被误删。
  • 新增回归测试,覆盖“普通 system 提示不展示给用户、inline log 仍保留”的场景。

验证结果:

  • go build ./... 通过
  • go test ./internal/tui/core/app/... 通过

未处理项:

  • go test ./... 仍会在 internal/gateway/client 命中一个已有并发测试失败;该问题与这次 TUI 修复无关,本次未改动。

View job run

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: phantom5099 <245659304+phantom5099@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Yumiue Yumiue merged commit 678f1f6 into 1024XEngineer:main May 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants