[BUGFIX] Eviter les automerges autres que 1024pix, node et lockfile maintenance (PIX-9553)#43
Merged
pix-service-auto-merge merged 1 commit intomainfrom Dec 7, 2023
Conversation
VincentHardouin
approved these changes
Dec 6, 2023
yannbertrand
changed the title
1024pix, node et lockfile maintenance1024pix, node et lockfile maintenance (PIX-9553)
yannbertrand
added
🚀 Ready to Merge
Tech Review OK
and removed
👀 Tech Review Needed
labels
pix-service-auto-merge
deleted the
fix-filter-out-non-automergeable-matchs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Notre stratégie de "pin" pour éviter les bumps auto ne fonctionne plus en l'état.
Toutes les applis ont par exemple bump
@fortawesome/fontawesome-svg-corequi était pinned.(Dans ce cas ci on s'en fiche un peu car c'était une erreur dans le package.json qu'on a corrigé)
Mais pour les deps qu'on a "pin" volontairement pour éviter les mises à jour auto on risque de péter un truc (voir la section "ignored or blocked" dans le dependency tracker)
🎁 Proposition
Rendre plus strict notre matching pour l'automerge, donc plus précisement :
@1024pixmineures et patchsnodemineures et patchs🧦 Remarques
RAS
🎅 Pour tester