fixes for compilation under Visual Studio #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsne/bh_sne_src/sptree.h
Outdated
| #pragma GCC visibility pop | ||
| #endif | ||
|
|
||
| #endif |
There was a problem hiding this comment.
This probably should have always been there but before there were other #if in here there wasn't anything to be confused about.
Suggested change
| #endif | |
| #endif // !defined(SPTREE_H) |
| @@ -53,7 +53,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
I think in windows we also need to define it as dllimport when included from places which are not this binary. If we're only building this into a binary, not as a dll on windows, then we shouldn't be using dllexport.
Author
There was a problem hiding this comment.
Given how we're using this, it wasn't strictly necessary. But I did it anyway.
and visibility fixes for visual studio
Author
|
I'm going to go ahead and merge this, if there are additional changes you would like I can address them in a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC pragmas aren't available (and visibility=hidden by default w/ VS), and __declspec must be all the way to the left.