Remove ripples and shadows on a bunch of objects floating in the water

[Jin-Jiyunsun]

The look pretty unnatural against 117HDs water, and this also makes everything consistent instead of there being a mix of ripples and no ripples

[Jin-Jiyunsun]

Updated to include a variable to tell if its a water effect or not and added it to a few other objects outside of what was initially covered in this PR

[aHooder]

I think we can move forward with this as long as we make it toggleable 🙂

[Jin-Jiyunsun]

Yeah it just needs to be implemented, I tagged all the instances with a placeholder variable for that

[RuffledPlume]

I can add it if someone else hasn't started already, just a "Show Water Effects" toggle under the "Environment" category will do right?

[aHooder]

I can add it if someone else hasn't started already, just a "Show Water Effects" toggle under the "Environment" category will do right?

Yep, something along those lines. I think ideally it would be clear that it's talking about vanilla effects somehow, though I'm not sure how to convey that really well.

[Jin-Jiyunsun]

Not sure what to call the toggle in the side bar, I guess "hide fake ripples" or "hide vanilla ripples"?

[aHooder]

Yeah, Hide vanilla ripples sounds good to me 👀 Perhaps we could poll whether to default it on or off

[RuffledPlume]

My only qualm is the Json says "isWaterEffect" & the config is specific to the water ripples. Are we sure it will only ever be used on ripples? 🤔

[Jin-Jiyunsun]

I think ripples makes sense on the config side, I called it effect because it covers a couple things that are not ripples, but for the end user "water effect" might be confusing?

[RuffledPlume]

Guess the config can always be updated if we ever expand it to other water stuff, Hide vanilla ripples it is

[RuffledPlume]

#947 Adds support for the new tag

[Jin-Jiyunsun]

Updated to support the latest tag, ready for merge.