Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project's coding standards to require trailing commas in function calls, declarations, and other applicable PHP constructs. The changes enforce the use of trailing commas for consistency and better version control diffs.
- Updates phpcs.xml to change from disallowing to requiring trailing commas in function calls, declarations, and closure use statements
- Adds trailing commas throughout the codebase to comply with the new coding standard
- Updates editor configuration to enforce trailing commas in PHP, JavaScript, and TypeScript
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| phpcs.xml | Changes coding standard rules from disallowing to requiring trailing commas |
| .editorconfig | Updates PHP, JavaScript, and TypeScript settings to enforce trailing commas when multiline |
| README.md | Reformats a long line by adding a line break |
| tests/Unit/Protocol/IppResponseParserTest.php | Adds trailing commas to multi-line function calls |
| tests/Unit/Operations/PrintOperationTest.php | Adds trailing comma to array return statement |
| tests/Unit/Operations/Cups/CupsDeletePrinterTest.php | Adds blank line for formatting |
| tests/Unit/Client/CupsIppHttpClientTest.php | Adds trailing commas to multi-line function calls |
| src/Protocol/IppResponseParser.php | Adds trailing commas to array and function calls |
| src/Protocol/IppOperation.php | Adds trailing comma to constructor parameters |
| src/Ipp.php | Adds trailing commas to constructor and service instantiation |
| src/Entity/IppPrintFile.php | Adds trailing comma to constructor parameters |
| src/Client/IppRequestException.php | Adds trailing comma to parent constructor call |
| src/Client/CupsIppHttpClient.php | Adds trailing commas to constructor and Request instantiations |
bram123
previously approved these changes
Jul 16, 2025
bram123
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.