Skip to content

Require trailing comma#10

Merged
RubenKluft merged 2 commits intomasterfrom
update_editorconfig_multiline_comma
Jul 16, 2025
Merged

Require trailing comma#10
RubenKluft merged 2 commits intomasterfrom
update_editorconfig_multiline_comma

Conversation

@RubenKluft
Copy link
Collaborator

No description provided.

@bram123 bram123 requested a review from Copilot July 16, 2025 11:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project's coding standards to require trailing commas in function calls, declarations, and other applicable PHP constructs. The changes enforce the use of trailing commas for consistency and better version control diffs.

  • Updates phpcs.xml to change from disallowing to requiring trailing commas in function calls, declarations, and closure use statements
  • Adds trailing commas throughout the codebase to comply with the new coding standard
  • Updates editor configuration to enforce trailing commas in PHP, JavaScript, and TypeScript

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
phpcs.xml Changes coding standard rules from disallowing to requiring trailing commas
.editorconfig Updates PHP, JavaScript, and TypeScript settings to enforce trailing commas when multiline
README.md Reformats a long line by adding a line break
tests/Unit/Protocol/IppResponseParserTest.php Adds trailing commas to multi-line function calls
tests/Unit/Operations/PrintOperationTest.php Adds trailing comma to array return statement
tests/Unit/Operations/Cups/CupsDeletePrinterTest.php Adds blank line for formatting
tests/Unit/Client/CupsIppHttpClientTest.php Adds trailing commas to multi-line function calls
src/Protocol/IppResponseParser.php Adds trailing commas to array and function calls
src/Protocol/IppOperation.php Adds trailing comma to constructor parameters
src/Ipp.php Adds trailing commas to constructor and service instantiation
src/Entity/IppPrintFile.php Adds trailing comma to constructor parameters
src/Client/IppRequestException.php Adds trailing comma to parent constructor call
src/Client/CupsIppHttpClient.php Adds trailing commas to constructor and Request instantiations

@bram123 bram123 self-requested a review July 16, 2025 11:16
bram123
bram123 previously approved these changes Jul 16, 2025
@RubenKluft RubenKluft merged commit a3bfc67 into master Jul 16, 2025
6 checks passed
@RubenKluft RubenKluft deleted the update_editorconfig_multiline_comma branch July 16, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants