Skip to content

Conversation

@frankdekker
Copy link
Member

@frankdekker frankdekker commented Jun 3, 2025

No description provided.

Copilot AI review requested due to automatic review settings June 3, 2025 12:10
@frankdekker frankdekker changed the title Update documentation to disable Sentry's tracing when enabling this t… Update documentation to disable Sentry's tracing when enabling this trace bundle Jun 3, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Sentry tracing configuration documentation and adds guidance to disable Sentry's own tracing when using the trace bundle.

  • Refines the info text in Configuration.php to mention disabling Sentry’s built-in tracing.
  • Updates traceid.md and tracecontext.md examples to accept a SentryConfig parameter and disable Sentry tracing.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/DependencyInjection/Configuration.php Expanded info message for the enabled node to mention disabling Sentry tracing
docs/configuration/traceid.md Adjusted example signature to include SentryConfig and disable Sentry tracing
docs/configuration/tracecontext.md Adjusted example signature to include SentryConfig and disable Sentry tracing
Comments suppressed due to low confidence (2)

docs/configuration/traceid.md:24

  • This example uses SentryConfig but there's no use statement importing it at the top—add the correct namespace import for SentryConfig.
return static function (SymfonyTraceConfig $config, ?SentryConfig $sentry): void {

docs/configuration/tracecontext.md:16

  • The example signature references SentryConfig but lacks a corresponding use import—please add the correct import for SentryConfig.
return static function (SymfonyTraceConfig $config, ?SentryConfig $sentry): void {

@frankdekker frankdekker merged commit 2d0b19f into master Jun 3, 2025
14 checks passed
@frankdekker frankdekker deleted the Update-documentation-for-sentry-support branch June 3, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants